[PATCH phosphor-event v2 1/2] Add delete for error logs

[Patrick Williams]

On Mon, Nov 23, 2015 at 01:40:22PM -0500, OpenBMC Patches wrote:
> From: Chris Austen <austenc at us.ibm.com>
> diff --git a/event_messaged.c b/event_messaged.c
> index b5d3ff1..15412d2 100644
> --- a/event_messaged.c
> +++ b/event_messaged.c
> @@ -14,26 +17,17 @@ typedef struct messageEntry_t {
>  	char    *association;
>  	uint8_t *debugbytes;
>  	size_t   debuglength;
> +	uint16_t logid;

IPMI uses 16 bit log ids, but do we need to?  Can we just use a size_t
instead?

> @@ -105,9 +86,9 @@ static int get_message_dd(sd_bus *bus,
> -// TODO Issue#2 Add method to erase all logs

Add 'Fixes openbmc/phosphor-event#2' to your commit message and it will
automatically close out this issue.  (Though I don't actually see an
issue in github for this...)

> +int get_new_log_number() {
> +	return ++g_logid;
> +}

Here you used an 'int' instead of a uint16_t or size_t.  Is this
intentional?

-- 
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20151123/2839ab5a/attachment.sig>