[PATCH phosphor-host-ipmid v3 1/6] Support host reboot
Stewart Smith
stewart at linux.vnet.ibm.com
Mon Dec 21 14:10:18 AEDT 2015
Vishwanatha Subbanna <vishwanath at in.ibm.com> writes:
> CMD_POWER_OFF is for soft-off.
>
> CMD_HARD_RESET is for hard reset.
Why not spell that out in the defines?
CMD_SOFT_POWER_OFF
CMD_HARD_RESET
which would imply the existence of:
CMD_HARD_POWER_OFF
CMD_SOFT_RESET
Having hard/soft in define means it's obvious to anyone reading the code
as to what it's meant to be doing.
More information about the openbmc
mailing list