[PATCH phosphor-host-ipmid v2] Add get/set ipmid command support with correct DBUS property handling.

OpenBMC Patches openbmc-patches at stwcx.xyz
Fri Dec 18 13:50:23 AEDT 2015


1) Two methods to handle the dbus property set and get:
    a) dbus_set_property()
    b) dbus_get_property()
2) The property is stored as a 10 character strings which representsd 5-byte information.
3) ipmid set method is registered and implemented since petitboot will use it to clear the boot options.
4) Get service name via object mapper
    a) The connection name is got via objectmapper.
    b) The method used to get the connection name is object_mapper_get_connection().
    c) dbus_get_property/dbus_set_property will get the connection name via the above method instead of hard coding.
5) Error code are properly handled.
6) Use sprinf/sscanf for int/string conversion.
    a) Instead of reinventing the wheel by defining methods converting int to string, use sprintf/sscanf should be a more clean and robust way.

https://github.com/openbmc/phosphor-host-ipmid/pull/55

shgoupf (1):
  Add get/set ipmid command support with correct DBUS property handling.

 chassishandler.C | 302 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 chassishandler.h |  17 ++++
 2 files changed, 315 insertions(+), 4 deletions(-)

-- 
2.6.3




More information about the openbmc mailing list