[PATCH phosphor-host-ipmid v4 2/2] Add get/set ipmid command support with correct DBUS property handling.

[Stewart Smith]

Peng Fei BG Gou <shgoupf at cn.ibm.com> writes:
> This commit has patches from a different commit
> As I have mentioned in my previous comments, please ignore this pull
> request and refer to the latest one:
> https://github.com/openbmc/phosphor-host-ipmid/pull/55
>
>
> Id there really a need for uint_to_char like functions?
> I believe so. Believe that is much more convenient for the conversion
> instead of hard coding.
>
>
> Sdbus seems to have a bug (or maybe I don't know how to use it) but unref
> of of a bus doesn't seem to work.  So you should not call sdbus_open   You
> should call the get_sbus (my correct spelling but I'm on a plane) function
> found in the ipmid.c. File
> I tested those codes, they worked fine. Seems you were talking about
> another bug?
>
>
> I've never seen a need to create free desktop functions not sure why they
> are here.   Attaching an object manager is a single function call.  See the
> phosphor-event repository
> Not sure what do you mean by "attaching an object manager". Actually what
> I'm doing is to call object manager and get the connection name with a
> specified object path.
>
> GOU, Peng Fei (苟鹏飞), Ph.D.
> OpenPower Team.
>
>
>
> From:	Chris Austen/Austin/IBM
> To:	"OpenBMC Patches" <openbmc-patches at stwcx.xyz>
> Cc:	Peng Fei BG Gou/China/IBM at ibmcn, "openbmc"
>             <openbmc at lists.ozlabs.org>
> Date:	12/17/2015 12:14 PM
> Subject:	Re: [PATCH phosphor-host-ipmid v4 2/2] Add get/set ipmid
>             command support with correct DBUS property handling.
>
>
>
> This commit has patches from a different commit
>
> Id there really a need for uint_to_char like functions?


You should fix your email client, there's a bunch of weird quoting going
on and then to posting without any quoting.