spufs platform dependent code

[Geoff Levand]

Arnd Bergmann wrote:
> On Saturday 28 January 2006 00:46, Geoff Levand wrote:
>>I found you have some stuff in there specific to your platform.
>>It assumes there is a certain south bridge, and that spu
>>interrupts are serviced by that south bridge.  It also makes
>>assumptions of how the spu's are represented in the device tree.
>>
>>I've got a first cut patch to break those things out.  I'll post
>>it soon for comment.
> 
> 
> The stuff that is specific to our south bridge should be fairly
> independant from anything that is related to spu code. If you have
> http://patchwork.ozlabs.org/linuxppc64/patch?id=4188 applied,
> it should already become a bit cleaner.
> 
> Since the base code is just using the internal interrupt controller
> interfaces that are specified in the CBE Architecture documents,
> I assumed they were pretty universal, even when using hcall interfaces
> instead of mmio access. Is that different for your implementation?


OK, maybe things can be be pushed down to lower level routines.


> Regarding the device tree representation of SPUs, we failed to
> document this properly in the past, but I strongly feel that we should
> standardize on a common representation before any system ships in
> large quantaties. Of course I would rather not have to make changes
> to our current firmware, but if you have requirements that can not
> be met with what we are doing now, we might get convinced to adapt
> to what you are doing or some compromize.


OK, I agree with you.  It will take me some time to gather the
details.  For now just refer to the split-out patch I posted.

-Geoff