[PATCH 2/5] powerpc: Make sure we don't create empty lmb regions

Michael Ellerman michael at ellerman.id.au
Wed Jan 25 19:31:26 EST 2006


To prevent problems later in boot, make sure we don't create zero-size lmb
regions.

I've checked all the callers, and at the moment no one should ever hit this.
All callers use a constant size, or they check the computed size before they
call us.

Signed-off-by: Michael Ellerman <michael at ellerman.id.au>
---

 arch/powerpc/mm/lmb.c |    4 ++++
 1 files changed, 4 insertions(+)

Index: linux/arch/powerpc/mm/lmb.c
===================================================================
--- linux.orig/arch/powerpc/mm/lmb.c
+++ linux/arch/powerpc/mm/lmb.c
@@ -197,6 +197,8 @@ long __init lmb_reserve(unsigned long ba
 {
 	struct lmb_region *_rgn = &(lmb.reserved);
 
+	BUG_ON(0 == size);
+
 	return lmb_add_region(_rgn, base, size);
 }
 
@@ -227,6 +229,8 @@ unsigned long __init lmb_alloc_base(unsi
 	long i, j;
 	unsigned long base = 0;
 
+	BUG_ON(0 == size);
+
 #ifdef CONFIG_PPC32
 	/* On 32-bit, make sure we allocate lowmem */
 	if (max_addr == LMB_ALLOC_ANYWHERE)



More information about the Linuxppc64-dev mailing list