powerpc: Cleanup LOADADDR etc. asm macros

linas linas at austin.ibm.com
Sat Jan 14 08:52:21 EST 2006


Hi,

On Fri, Jan 13, 2006 at 02:56:25PM +1100, David Gibson was heard to remark:
> 
> to make it more obvious which is the appropriate one to use in a given
> situation.  

...

> + * LOAD_REG_ADDR(rn, name)
> + *   Loads the address of label 'name' into register 'rn'.  Use this when

...

> -#define SET_REG_TO_LABEL(reg, label)	         	\

Mabe its just me, but I do find the name "set reg to label" to be more
intiuitive than "load reg addr".  Something like "LOAD_ADDR_OF_LABEL"
would have been nearly ideal. 

--linas



More information about the Linuxppc64-dev mailing list