[PATCH 1/4] powerpc: Add firmware_set_feature()

Michael Ellerman michael at ellerman.id.au
Fri Jan 13 11:26:55 EST 2006


On Fri, 13 Jan 2006 01:41, Arnd Bergmann wrote:
> On Thursday 12 January 2006 07:10, Michael Ellerman wrote:
> > I think we should definitely mask, we don't want to end up with
> > imPOSSIBLE features being turned on. BUG_ON might be appropriate, it
> > would at least catch people who forget to add features to the POSSIBLE
> > map - is there any way to cause it to fail at build time though?
>
> There is BUILD_BUG_ON() that should do exactly that.

Except it doesn't work :( We could do some ugly hack to cause a link error, 
but that's gross.

Seeing as Paulus doesn't like it, and he's the man with the keys to the git 
tree, I think I'll just can the patch.

cheers

-- 
Michael Ellerman
IBM OzLabs

email: michael:ellerman.id.au
inmsg: mpe:jabber.org
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 185 bytes
Desc: not available
Url : http://ozlabs.org/pipermail/linuxppc64-dev/attachments/20060113/fe66b201/attachment.pgp 


More information about the Linuxppc64-dev mailing list