[PATCH 1/3] msi vector targeting abstractions

Paul Mackerras paulus at samba.org
Thu Jan 12 16:47:27 EST 2006


Grant Grundler writes:

> > +	if ((status = msi_arch_init()) < 0) {
> 
> Willy told me I should always complain about assignment in if() statements :)

We are getting incredibly politically correct these days, aren't we.

I see nothing wrong with that if statement.  It's perfectly valid,
idiomatic C.  You can ignore Willy if you like. :)

(I would look askance at something that did an assignment as one of
the parameters of a procedure call in an if statement, though.)

Paul.



More information about the Linuxppc64-dev mailing list