[PATCH] powerpc: add ibm,suspend-me rtas interface

[Olof Johansson]

On Wed, Jan 11, 2006 at 11:43:53AM -0600, Dave C Boutcher wrote:
> On Wed, Jan 11, 2006 at 11:12:52AM -0600, Olof Johansson wrote:
> > On Wed, Jan 11, 2006 at 03:56:33AM -0600, Dave C Boutcher wrote:
> > In general, you seem to have some whitespace issues -- 4 spaces instead
> > of tabs, 2 tabs instead of 1 in one place, and some trailing whitespace.
> > I won't comment on the specific instances but please clean them up.
> 
> Sigh...I'll fix and respin.
> 
> > 
> > If you use Vim, the following in your .vimrc will make some of them
> > stand out easily:
> 
> VIM!!! you heretic.

Oh, I wasn't trying to push an editor on you, just give a useful tip in
case you were using it. :)

> > However, a bigger question is: why are you defining your own interface
> > for suspend? There's already at least one global interface for it
> > (/sys/power/state), can't you hook in there instead? This means we'll
> > have to carry another interface forever, since userspace tools will
> > depend on it.
> 
> This suspend is not (sigh) the same as linux suspend.  I might have 
> tried to rename it something different, but the RTAS call is 
> "ibm,suspend-me".  This is going to be driven by the HMC ultimately.
> 
> This function doesn't preclude someone implementing one of the Linux
> swsusp versions on Power (and in fact Santi was working on that last 
> year.)

Ok, good to know. I suggest a comment about it in the patch description
to avoid repeated questions.

> > Why?!
> 
> Because I'm paranoid about everyone accessing that shared waiting flag.

Ah, you probably want an smp_wmb() then instead. :-)

> The rest of the comments are fair enough and I'll fix them up.  Thanks
> for the review.

Thanks.


-Olof