[PATCH] ppc64: per cpu data optimisations

Anton Blanchard anton at samba.org
Wed Jan 11 15:19:11 EST 2006


Hi Nathan,

> Anton Blanchard wrote:
> > +#define percpu_modcopy(pcpudst, src, size)			\
> > +do {								\
> > +	unsigned int __i;					\
> > +	for (__i = 0; __i < NR_CPUS; __i++)			\
> > +		if (cpu_possible(__i))				\
> 
> Nitpick - could be for_each_cpu(__i)?  Or am I missing something
> subtle?

Makes sense, although this is straight out of the asm-generic percpu
code. Might be worth a patch to attack the 5 versions of percpu_modcopy
that all do the above :)

Anton



More information about the Linuxppc64-dev mailing list