[PATCH] ppc64 - fix spinlock recursion in native_hpte_clear

[R Sharada]

Would something to this effect be more appropriate?

/* we already hold the native_tlbie_lock before getting here. So, cannot
 * take it back again. So call raw __tlbie() in here
 */

Thanks and Regards,
Sharada

On Thu, Feb 23, 2006 at 10:49:18AM +1100, Michael Ellerman wrote:
> On Thu, 23 Feb 2006 09:50, Geoff Levand wrote:
> > R Sharada wrote:
> > > linux-2.6.16-rc4/arch/powerpc/mm/hash_native_64.c~fix_native_hpte_clear
> > > 2006-02-22 21:22:42.000000000 +0530
> > > +++ linux-2.6.16-rc4-sharada/arch/powerpc/mm/hash_native_64.c
> > > 2006-02-22 21:26:25.000000000 +0530
> > > @@ -403,12 +403,16 @@ static void native_hpte_clear(void)
> > >  		 */
> > >  		hpte_v = hptep->v;
> > >
> > > +		/* tlbie() takes the native_tlbie_lock. hence change the
> > > +		 * tlbie() call here to __tlbie()
> > > +		 */
> >
> > Once the patch is applied, the tlbie() call disappears and you have
> > comment that doesn't make sense in the new context.  Maybe you should
> > reconsider the wording.
> 
> Yeah I agree with Geoff. The point is that we already hold the tlbie lock, so 
> we can't call something that takes it again.
> 
> cheers
> 
> -- 
> Michael Ellerman
> IBM OzLabs
> 
> wwweb: http://michael.ellerman.id.au
> phone: +61 2 6212 1183 (tie line 70 21183)
> 
> We do not inherit the earth from our ancestors,
> we borrow it from our children. - S.M.A.R.T Person