[PATCH 1/2] EEH cleanups

Linas Vepstas linas at austin.ibm.com
Wed Feb 22 08:14:02 EST 2006


Hi,

On Tue, Feb 21, 2006 at 02:53:38PM -0600, John Rose was heard to remark:
> This patch removes unnecessary exports, marks functions as static when
> possible, and simplifies some list-related code.
> 
> Signed-off-by: John Rose <johnrose at austin.ibm.com>

Looks reasonable to me; I have one request, though. The patch
removes the following documentatin from eeh.h; can you copy 
this over to eeh.c? (what's there now is shorter and has 
a typo.)

>  /**
> - * eeh_remove_device - undo EEH setup for the indicated pci device
> - * @dev: pci device to be removed
> - *
> - * This routine should be called when a device is removed from
> - * a running system (e.g. by hotplug or dlpar).  It unregisters
> - * the PCI device from the EEH subsystem.  I/O errors affecting
> - * this device will no longer be detected after this call; thus,
> - * i/o errors affecting this slot may leave this device unusable.
> - */

I won't be here tommorrow, to ack anything revised then, 
so I'll just ack now:

Acked-by: Linas Vepstas <linas at austin.ibm.com>

--linas




More information about the Linuxppc64-dev mailing list