[openib-general] [PATCH 08/22] Generic ehca headers
Christoph Hellwig
hch at lst.de
Sun Feb 19 02:09:20 EST 2006
On Fri, Feb 17, 2006 at 04:57:23PM -0800, Roland Dreier wrote:
> From: Roland Dreier <rolandd at cisco.com>
>
> The defines of TRUE and FALSE look rather useless. Why are they needed?
>
> What is struct ehca_cache for? It doesn't seem to be used anywhere.
>
> ehca_kv_to_g() looks completely horrible. The whole idea of using
> vmalloc()ed kernel memory to do DMA seems unacceptable to me.
When you want to do scatter-gather dma on kernel-virtual contingous
areas allocate the pages individually and map them into kva using
vmap(). Then dma can be performed using dma_map_page, or in case
you have lots of pages dma_map_sg after creating an S/G list.
More information about the Linuxppc64-dev
mailing list