[PATCH] PPC64 collect and export low-level cpu usage statistics

David Gibson dwg at au1.ibm.com
Thu Feb 16 20:10:27 EST 2006


On Wed, Feb 15, 2006 at 10:44:02PM -0600, Manish Ahuja wrote:
[snip]
> >>Index: linux-2.6.15-rc6/arch/powerpc/kernel/process.c
> >>===================================================================
> >>--- linux-2.6.15-rc6.orig/arch/powerpc/kernel/process.c	2005-12-18 
> >>16:36:54.000000000 -0800
> >>+++ linux-2.6.15-rc6/arch/powerpc/kernel/process.c	2006-01-17 
> >>21:20:25.000000000 -0800
> >>@@ -243,6 +243,7 @@
> >>	struct thread_struct *new_thread, *old_thread;
> >>	unsigned long flags;
> >>	struct task_struct *last;
> >>+	struct paca_struct *lpaca;
> >>   
> >>
> >
> >This could have been declared below (near pd)
> 
> Yes... But it seems fine there..

Actually, I've been trying to get rid of lpaca locals everywhere.
Using get_paca() directly is barely more verbose, and usually clearer.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson



More information about the Linuxppc64-dev mailing list