[PATCH] powerpc: hypervisor check in pseries_kexec_cpu_down

Michael Neuling mikey at neuling.org
Tue Feb 7 11:58:16 EST 2006


> Is SPLPAR the right test? I would have thought LPAR?

I missed your patch which added this but you're right.

Revised patch attached.  Now depends on MPE's patches from here:
http://patchwork.ozlabs.org/linuxppc64/patch?id=4088

--
We call unregister_vpa but we don't check to see if the hypervisor
supports this.

Signed-off-by: Michael Neuling <mikey at neuling.org>

 arch/powerpc/platforms/pseries/setup.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6-powerpc/arch/powerpc/platforms/pseries/setup.c
===================================================================
--- linux-2.6-powerpc.orig/arch/powerpc/platforms/pseries/setup.c
+++ linux-2.6-powerpc/arch/powerpc/platforms/pseries/setup.c
@@ -585,7 +585,7 @@ static int pSeries_pci_probe_mode(struct
 static void pseries_kexec_cpu_down(int crash_shutdown, int secondary)
 {
 	/* Don't risk a hypervisor call if we're crashing */
-	if (!crash_shutdown) {
+	if (firmware_has_feature(FW_FEATURE_LPAR) && !crash_shutdown) {
 		unsigned long vpa = __pa(get_lppaca());
 
 		if (unregister_vpa(hard_smp_processor_id(), vpa)) {



More information about the Linuxppc64-dev mailing list