Hugepages need clear_user_highpage() not clear_highpage()

William Lee Irwin III wli at holomorphy.com
Mon Feb 6 19:19:39 EST 2006


On Mon, Feb 06, 2006 at 01:18:53PM +1100, David Gibson wrote:
> When hugepages are newly allocated to a file in mm/hugetlb.c, we clear
> them with a call to clear_highpage() on each of the subpages.  We
> should be using clear_user_highpage(): on powerpc, at least,
> clear_highpage() doesn't correctly mark the page as icache dirty so if
> the page is executed shortly after it's possible to get strange
> results.
> This is a bugfix and should go into 2.6.16.
> Signed-off-by: David Gibson <dwg at au1.ibm.com>

Not sure how this got past the usual crapfilters. Sorry about that.

Acked-by: William Irwin <wli at holomorphy.com>


-- wli



More information about the Linuxppc64-dev mailing list