[PATCH 1/2] Unify numa_memory_lookup_table allocation and setup.

Paul Mackerras paulus at samba.org
Thu Sep 29 10:35:30 EST 2005

Dave Hansen writes:

> The LMB macro patch certainly makes some of the code more readable.
> But, it might not be worth it to use the macro in lmb.c.  It just seems
> to make it more complicated.  Any thoughts?

It does seem to make it more complicated.

IMO, when we have a file such as lmb.c whose purpose is to present an
abstraction to the rest of the kernel, there is no point in
abstracting further within that, and in fact it actually obscures
things - when you go looking at how the abstraction is implemented,
you want to see how the abstraction is implemented, not some further

The for_each_lmb_region macro would be useful if we expected random
users of the lmb stuff to need to go iterating through lmb regions.
Since all such iterations are confined to lmb.c, I don't think the
patch is helpful.


More information about the Linuxppc64-dev mailing list