[PATCH] ppc64: fix lparcfg datatype and bad math.

will schmidt will_schmidt at vnet.ibm.com
Tue Sep 13 23:19:40 EST 2005

Paul Mackerras wrote:
> will schmidt writes:
>>This patch fixes two problems with the string parsing code out of lparcfg.
>>First, it changes the data type of a char array to be unsigned.  This 
>>prevents some nasty behavior when the code is built with -fsigned-char, 
> OK, making it explicitly unsigned char is good, but why would we ever
> build the kernel with -fsigned-char?
> Paul.

I dont know why we would build with -fsigned-char.   It appears that we 
used to build that way (at least, back in 2.4), I dont recall the 
discussions surrounding removing that flag, so only really mention the 
parm because it took a bit to figure out. :-)


More information about the Linuxppc64-dev mailing list