[PATCH] Use PLATFORM_LPAR rather than PLATFORM_PSERIES_LPAR

Segher Boessenkool segher at kernel.crashing.org
Tue Sep 13 19:23:02 EST 2005


>>> This patch allows for a both furure PLATFORM_[MAPLE|CELL]_LPAR
>>> platforms to share PSERIES_LPAR code.
>
>  DG> I think we would be better off using new firmware_has_feature() 
> bits
>  DG> for this.  It takes us a step closer to a kernel which can boot 
> both
>  DG> pSeries and iSeries and a step closer to getting rid of the magic
>  DG> platform numbers entirely.
>
> hmm, not sure if I would equate "platform" with "firmware".
> Perhaps when this gets pushed into prom_init.c we could use it, but
> currently it is initialized too late.

There _is_ no such thing as a platform; it is completely the
wrong concept to do any feature tests on.  Yes, put some LPAR
detection code into prom_init.c, and use it from there.

Care to prepare a patch for this?

If not, please get your original patch in, as although it isn't
perfect, it already is better than what was there before.


Segher




More information about the Linuxppc64-dev mailing list