[PATCH] ppc64: Use num_pmcs in oprofile code

Anton Blanchard anton at samba.org
Tue Sep 6 14:52:12 EST 2005


Change oprofile to use num_pmcs from the cpu feature struct.

Signed-off-by: Anton Blanchard <anton at samba.org>

Index: build/arch/ppc64/oprofile/common.c
===================================================================
--- build.orig/arch/ppc64/oprofile/common.c	2005-09-05 16:11:18.000000000 +1000
+++ build/arch/ppc64/oprofile/common.c	2005-09-05 20:54:34.000000000 +1000
@@ -16,6 +16,7 @@
 #include <asm/ptrace.h>
 #include <asm/system.h>
 #include <asm/pmc.h>
+#include <asm/cputable.h>
 
 #include "op_impl.h"
 
@@ -131,7 +132,6 @@
 		case PV_630:
 		case PV_630p:
 			model = &op_model_rs64;
-			model->num_counters = 8;
 			ops->cpu_type = "ppc64/power3";
 			break;
 
@@ -140,14 +140,12 @@
 		case PV_ICESTAR:
 		case PV_SSTAR:
 			model = &op_model_rs64;
-			model->num_counters = 8;
 			ops->cpu_type = "ppc64/rs64";
 			break;
 
 		case PV_POWER4:
 		case PV_POWER4p:
 			model = &op_model_power4;
-			model->num_counters = 8;
 			ops->cpu_type = "ppc64/power4";
 			break;
 
@@ -155,14 +153,12 @@
 		case PV_970FX:
 		case PV_970MP:
 			model = &op_model_power4;
-			model->num_counters = 8;
 			ops->cpu_type = "ppc64/970";
 			break;
 
 		case PV_POWER5:
 		case PV_POWER5p:
 			model = &op_model_power4;
-			model->num_counters = 6;
 			ops->cpu_type = "ppc64/power5";
 			break;
 
@@ -170,6 +166,7 @@
 			return -ENODEV;
 	}
 
+	model->num_counters = cur_cpu_spec->num_pmcs;
 	ops->create_files = op_ppc64_create_files;
 	ops->setup = op_ppc64_setup;
 	ops->shutdown = op_ppc64_shutdown;
Index: build/arch/ppc64/oprofile/op_model_power4.c
===================================================================
--- build.orig/arch/ppc64/oprofile/op_model_power4.c	2005-09-05 16:11:18.000000000 +1000
+++ build/arch/ppc64/oprofile/op_model_power4.c	2005-09-05 20:53:01.000000000 +1000
@@ -23,7 +23,6 @@
 
 static unsigned long reset_value[OP_MAX_COUNTER];
 
-static int num_counters;
 static int oprofile_running;
 static int mmcra_has_sihv;
 
@@ -45,8 +44,6 @@
 {
 	int i;
 
-	num_counters = num_ctrs;
-
 	/*
 	 * SIHV / SIPR bits are only implemented on POWER4+ (GQ) and above.
 	 * However we disable it on all POWER4 until we verify it works
@@ -68,7 +65,7 @@
 
 	backtrace_spinlocks = sys->backtrace_spinlocks;
 
-	for (i = 0; i < num_counters; ++i)
+	for (i = 0; i < cur_cpu_spec->num_pmcs; ++i)
 		reset_value[i] = 0x80000000UL - ctr[i].count;
 
 	/* setup user and kernel profiling */
@@ -121,7 +118,7 @@
 	/* set the PMM bit (see comment below) */
 	mtmsrd(mfmsr() | MSR_PMM);
 
-	for (i = 0; i < num_counters; ++i) {
+	for (i = 0; i < cur_cpu_spec->num_pmcs; ++i) {
 		if (ctr[i].enabled) {
 			ctr_write(i, reset_value[i]);
 		} else {
@@ -272,7 +269,7 @@
 	/* set the PMM bit (see comment below) */
 	mtmsrd(mfmsr() | MSR_PMM);
 
-	for (i = 0; i < num_counters; ++i) {
+	for (i = 0; i < cur_cpu_spec->num_pmcs; ++i) {
 		val = ctr_read(i);
 		if (val < 0) {
 			if (oprofile_running && ctr[i].enabled) {



More information about the Linuxppc64-dev mailing list