[PATCH 3/5] powerpc: Move plpar_wrappers.h into include/asm-powerpc

Arnd Bergmann arnd at arndb.de
Mon Oct 24 21:42:20 EST 2005


On Maandag 24 Oktober 2005 13:09, Michael Ellerman wrote:
> It looks like those firmware features will only ever be true on pSeries, so we 
> could make it a ppc_md, with everyone except pSeries having a null callback. 

I rather thought of making the callback point to set_dabr_spr for everything
except pSeries and get rid of set_dabr(), but that's just a detail.

> I'm not sure how crazy we want to get with ppc_md though? It already has 52 
> members for PPC64, 74 all up.

Yes, that certainly is a problem. It has the potential to become a horrible
mess if it isn't already. Maybe that should be revisited later, but IMHO
it seems to be the right abstraction here because it helps get the code
layering clearer.

There is always a tradeoff between using ppc_md, smp_ops, 
systemcfg->platform, ppc64_firmware_features, cur_cpu_spec->cpu_features 
and compile-time decisions. Maybe we already have too many mechanisms to
do the same thing (or not enough), and probably we're using the wrong
abstraction in some places, but figuring that out can become a very long
discussion...

	Arnd <><



More information about the Linuxppc64-dev mailing list