[PATCH 10/11] powerpc: Add helper functions for synthesising instructions at runtime

[Segher Boessenkool]

> I agree with you, Segher's code is obfuscated. Your current coding
> is much easier to read for someone that doesn't know the instruction
> bitfield layout by heart. The saved instructions on doing it Segher's
> way are not critical since it's not during a runtime hot path that this
> is called. Go for readability instead.

Well I think it is much more readable, we'll just have to
disagree here.  That's just fine, it's not my code :-)

> Actually documenting Segher's code so it's as easy to understand will
> make it just as large as your current one (i.e. your 7 lines, his 3
> lines).

Nah, it removes more comments than it would add ;-)


Segher