[PATCH] ppc64: Thermal control for SMU based machines

linas linas at austin.ibm.com
Wed Oct 19 06:57:10 EST 2005


On Wed, Oct 12, 2005 at 10:24:51AM +1000, Benjamin Herrenschmidt was heard to remark:
> > > +#define BUILD_SHOW_FUNC_FIX(name, data)				\
> > > +static ssize_t show_##name(struct device *dev,                  \
> > > +			   struct device_attribute *attr,       \
> > > +			   char *buf)	                        \
> > > +{								\
> 
> Ahh no, the problem here is that stupid emacs is very bad with tab
> and multi-line macros and just turns the whole thing into shit, so
> I used spaces. Sorry, I'm not an emacs guru and don't know how to
> work around that ...

Anyone who has tabstops set to 3 instead of 8 will see broken-ness for
macros like this no matter what. Suggest that the right policy is to use
only spaces, and neve tabs, inside of macros.

--linas



More information about the Linuxppc64-dev mailing list