[PATCH] ppc64: Crash in DLPAR code on PCI hotplug add

Alexey Dobriyan adobriyan at gmail.com
Tue Oct 4 07:34:30 EST 2005


On Mon, Oct 03, 2005 at 01:57:39PM -0500, linas wrote:
> The root cause was that the phb was not marked "dynamic", and so instead
> of having kmalloc() being called, the __init __alloc_bootmem() was called,
> resulting in access of garage data.  The patch below fixes this crash,
> and adds some docs to clarify the code.

> +/** pci_devs_phb_init_dynamic -- setup pci devices under this PHB
> + *
> + * This routine is called both during boot, (before the memory
> + * subsystem is set up, before kmalloc is valid) and during the 
> + * dynamic lpar operation of adding a PHB to a running system.
> + */
>  void __devinit pci_devs_phb_init_dynamic(struct pci_controller *phb)

Please, add docs in a proper way:

	/**
	 * foo - bar
	 * a: b
	 *
	 * Does bar.
	 */




More information about the Linuxppc64-dev mailing list