[PATCH] Avoid use of uninitialised spinlock in EEH.

[David Woodhouse]

On Wed, 2005-11-16 at 15:41 -0600, linas wrote:
> It seems that I missed the begining of this conversation;

I've attached the mail which started it.

> There already is a global flag, computed at boot time, that indicates if
> there's EEH hardware on the system: its called "eeh_subsystem_enabled".

Yes, that's what my original patch used, although it had to export it.

> > Paulus, the reason your G5 doesn't die with CONFIG_EEH set is because
> > you haven't got spinlock debugging. Try turning that on too :)
> 
> ? What is the specific problem? EEH uses very few spinlocks; I'm having
> trouble imagining what the problem is.

The problem is that eeh_init() is never called, because we're not
running on a pSeries. But eeh_check_failure() is still called, and tries
to lock a spinlock which was never initialised.

-- 
dwmw2

-------------- next part --------------
An embedded message was scrubbed...
From: David Woodhouse <dwmw2 at infradead.org>
Subject: [PATCH] Avoid use of uninitialised spinlock in EEH.
Date: Wed, 21 Sep 2005 18:14:59 +0100
Size: 4403
Url: http://ozlabs.org/pipermail/linuxppc64-dev/attachments/20051116/82946d2a/attachment.eml