[PATCH] spufs: Make all exports GPL-only

Arnd Bergmann arnd at arndb.de
Thu Nov 17 01:26:40 EST 2005


This changes all exported symbols of spufs to EXPORT_SYMBOL_GPL.
The spu_ibox_read/spu_wbox_write symbols are not exported
any more when the scheduler patch is applied.

Signed-off-by: Arnd Bergmann <arndb at de.ibm.com>

---

On Middeweken 16 November 2005 02:41, Andrew Morton wrote:
> +EXPORT_SYMBOL_GPL(hash_page);
> +EXPORT_SYMBOL(spu_alloc);
> +EXPORT_SYMBOL(spu_free);
> +EXPORT_SYMBOL(spu_run);
> +EXPORT_SYMBOL(spu_ibox_read);
> +EXPORT_SYMBOL(spu_wbox_write);
> +EXPORT_SYMBOL_GPL(register_spu_syscalls);
> +EXPORT_SYMBOL_GPL(unregister_spu_syscalls);
> -EXPORT_SYMBOL_GPL(__handle_mm_fault); /* For MOL */
> +EXPORT_SYMBOL_GPL(__handle_mm_fault);
> 
> A strange mixture of GPL and non-GPL.   What's the thinking here?

Lack of thinking ;-)
At first, I had everything as EXPORT_SYMBOL. Everything that was added
in the last few months was EXPORT_SYMBOL_GPL.

Index: linux-2.6.15-rc/arch/powerpc/platforms/cell/spu_base.c
===================================================================
--- linux-2.6.15-rc.orig/arch/powerpc/platforms/cell/spu_base.c
+++ linux-2.6.15-rc/arch/powerpc/platforms/cell/spu_base.c
@@ -399,7 +399,7 @@ struct spu *spu_alloc(void)
 
 	return spu;
 }
-EXPORT_SYMBOL(spu_alloc);
+EXPORT_SYMBOL_GPL(spu_alloc);
 
 void spu_free(struct spu *spu)
 {
@@ -407,7 +407,7 @@ void spu_free(struct spu *spu)
 	list_add_tail(&spu->list, &spu_list);
 	up(&spu_mutex);
 }
-EXPORT_SYMBOL(spu_free);
+EXPORT_SYMBOL_GPL(spu_free);
 
 static int spu_handle_mm_fault(struct spu *spu)
 {
@@ -576,7 +576,7 @@ int spu_run(struct spu *spu)
 
 	return ret;
 }
-EXPORT_SYMBOL(spu_run);
+EXPORT_SYMBOL_GPL(spu_run);
 
 static void __iomem * __init map_spe_prop(struct device_node *n,
 						 const char *name)




More information about the Linuxppc64-dev mailing list