[PATCH] GX bus support

Christoph Hellwig hch at lst.de
Mon Nov 14 22:56:47 EST 2005


On Mon, Nov 14, 2005 at 07:16:40PM +1100, Benjamin Herrenschmidt wrote:
> This patch adds the necessary core bus support used by device drivers
> that sit on the IBM GX bus on modern pSeries machines like the Galaxy
> infiniband for example. It provide transparent DMA ops (the low level
> driver works with virtual addresses directly) along with a simple bus
> layer using the Open Firmware matching routines.

Why is this called ebus in the source when you call it GX bus here?
This is specially confusing as we already support an 'ebus' on the
sparc port.

> @@ -0,0 +1,372 @@
> +/*
> + * IBM PowerPC eBus Infrastructure Support.
> + *
> + * Copyright (c) 2005 IBM Corporation
> + *  Heiko J Schick <schickhj at de.ibm.com>
> + *
> + * All rights reserved.
> + *
> + * This source code is distributed under a dual license of GPL v2.0 and OpenIB
> + * BSD.
> + *
> + * OpenIB BSD License
> + *
> + * Redistribution and use in source and binary forms, with or without

folks, can we please have everything under arch/powerpc/ just licensed
under plain GPL?  Especially as this is obviously a derived work of the
kernel and could hardly be used anywhere else.

> +static void *ebus_alloc_coherent(struct device *dev,
> +				 size_t size,
> +				 dma_addr_t *dma_handle,
> +				 unsigned int __nocast flag)
> +{
> +	return NULL;

this should be a kmalloc for consistencies sake.

> +struct ebus_dev* __devinit ebus_register_device_node(struct device_node *dn)

wrong placement of the '*'




More information about the Linuxppc64-dev mailing list