[PATCH 11/12] powerpc: Add arch-dependant copy_oldmem_page

Michael Ellerman michael at ellerman.id.au
Tue Nov 8 10:48:32 EST 2005


On Tue, 8 Nov 2005 00:17, Dave Hansen wrote:
> On Tue, 2005-11-08 at 00:07 +1100, Michael Ellerman wrote:
> > --- kexec.orig/include/asm-powerpc/kexec.h
> > +++ kexec/include/asm-powerpc/kexec.h
> > @@ -30,6 +30,8 @@
> >  #define KEXEC_ARCH KEXEC_ARCH_PPC
> >  #endif
> >
> > +#define HAVE_ARCH_COPY_OLDMEM_PAGE
> > +
> >  #ifndef __ASSEMBLY__
>
> Isn't something like that more properly done in Kconfig?  I find it very
> hard to trace down exactly what CONFIG options it takes to get some of
> those #defines to happen.  Kconfig makes it much more clear.

That's a bit of a hack at the moment, you might be right that Kconfig would be 
better. I believe there's some guys working on Kdump for x86-64 that have 
already got the generic infrastructure for this in place, so we'll wait and 
see what they've done.

cheers

-- 
Michael Ellerman
IBM OzLabs

email: michael:ellerman.id.au
inmsg: mpe:jabber.org
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://ozlabs.org/pipermail/linuxppc64-dev/attachments/20051108/18b966fb/attachment.pgp 


More information about the Linuxppc64-dev mailing list