[PATCH] remove io_page_mask

Anton Blanchard anton at samba.org
Mon May 30 07:32:42 EST 2005


Hi,

> I found an issue with the io_page_mask code when pci_probe_only is not
> set (we dont initialise io_page_mask and bad things happen). I was 
> about to fix it up when I wondered if we can remove it now.
> 
> Ben changed the serial code to check before it goes pounding on
> addresses. Im not sure if there were other issues with badly behaving
> drivers but my js20 boots here with the following removal patch.

I tried inserting and removing every module that we currently compile. I
found one more fail in the pcspkr driver.

Is someone in the mood to convert these two drivers to use the legacy IO
helpers? If so we can merge the io port removal patch.

Anton

cpu 0x0: Vector: 300 (Data Access) at [c000000001fb7a20]
    pc: d0000000001be1b8: .pcspkr_event+0x1b8/0x228 [pcspkr]
    lr: d0000000001be054: .pcspkr_event+0x54/0x228 [pcspkr]
   dar: 61
0:mon> t
c000000000077f04 .sys_delete_module+0x22c/0x330

cpu 0x1: Vector: 300 (Data Access) at [c000000002e33970]
    pc: d0000000002ec2f8: .parport_pc_probe_port+0x67c/0xbac [parport_pc]
    lr: d0000000002ec2d4: .parport_pc_probe_port+0x658/0xbac [parport_pc]
   dar: 3be
1:mon> t
d0000000002edbb8 .parport_pc_init+0x2bc/0x494 [parport_pc]
c000000000079fc8 .sys_init_module+0x2cc/0x4a8



More information about the Linuxppc64-dev mailing list