[PATCH] FYI/ Re: PCI Error Recovery API Proposal (updated)

John Rose johnrose at austin.ibm.com
Sat May 14 03:40:28 EST 2005


Hi Linas-

> Suggestions where these should go? They got moved from arch/ppc64/kernel
> to drivers/pci/hotplug at the urging of Paulus and GregKH; in part because 
> rpaphp can be built as a module, whereas the the ppc64 bits cannot.  
> Would a distinct file in drivers/pci/hotplug work? Or someething else?

Paul, Greg, can you explain the motivation behind this?  Why doesn't the
EEH recovery logic belong in eeh.c, with the rest of EEH code?

> > Could you just use pci_device_to_OF_node(), then dn->phb?  This way, 
> > you could avoid the loop.
> 
> Yes, except that not all dn's have phb's.  The goal here is to walk up
> the tree, until a phb is found.

If a PCI node had a null phb pointer, that would be a bug :)  This
pointer should be set for nodes present at boot as well as dynamically
added ones.

Thanks-
John




More information about the Linuxppc64-dev mailing list