[PATCH 1/3] ppc64: iseries_veth: Don't send packets to LPARs which aren't up

[David Gibson]

On Tue, May 10, 2005 at 04:00:08PM +1000, Michael Ellerman wrote:
> On Tue, 10 May 2005 09:04, Michael Ellerman wrote:
> > On Tue, 10 May 2005 03:27, David Howells wrote:
> > > Michael Ellerman <michael at ellerman.id.au> wrote:
> > > > The iseries_veth driver has a logic bug which means it will erroneously
> > > > send packets to LPARs for which we don't have a connection.
> > >
> > > Any particular versions of the kernel?
> >
> > 2.6.* I believe. Certainly RHEL4's version is broken.
> >
> > I haven't got an RHEL3 kernel handy, but the 2.6 driver was based on the
> > 2.4 version I believe, so it's possible the bug is in 2.4 too.
> 
> Well something was based on something, no one's quite sure. But the 2.4 driver 
> looks ok, it doesn't have this code at all.

The 2.6 driver is based on the 2.4 driver in the sense that the 2.4
driver was the only source of information about the virtual ethernet
protocol.  However, the driver was pretty much completely rewritten in
the process.  Unfortunately, this seems to have introduce quite a few
bugs like these ones.  On the other hand, the code is now
comprehensible so the bugs are actually fixable..

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/people/dgibson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://ozlabs.org/pipermail/linuxppc64-dev/attachments/20050511/7fcaaf61/attachment.pgp