[PATCH 1/2] ppc64: fix read/write on large /dev/nvram

Arnd Bergmann arnd at arndb.de
Tue May 3 19:46:03 EST 2005


On Maandag 02 Mai 2005 08:43, Milton Miller wrote:
> On Fri Apr 22 16:49:59 EST 2005, Arnd wrote a patch with the following
> lines (among several others).
> 
> -       len = ppc_md.nvram_read(tmp_buffer, count, ppos);
> +       ret = ppc_md.nvram_read(tmp, count, ppos);
> 
> -       len = ppc_md.nvram_write(tmp_buffer, count, ppos);
> +       ret = ppc_md.nvram_read(tmp, count, ppos);
> 
> 
> Even though I am just scanning, I am guessing this is not quite right.

Good catch. I only tested the read path because I did not want to
mess with the contents of the nvram. I'll do a new patch when I
come back to Germany, unless someone else (Utz?) does one first.

	Arnd <><



More information about the Linuxppc64-dev mailing list