[PATCH] Trim careful_alocation()

Anton Blanchard anton at samba.org
Thu Mar 31 07:25:55 EST 2005


Hi Mike,

> The following patch removes the call to __alloc_bootmem_node() in
> careful_allocation().  Note that careful_allocation is only called
> in two places:
> 1) to allocate the node pglist_data structure
> 2) to allocate the bootmem map for the node
> As such, calling __alloc_bootmem_node to allocate space for these
> items makes no sense.  You can't use the bootmem allocator to create
> the initial data structures for the bootmem allocator.

On NUMA kernels we create NUMA nodes for all possible nodes. If that
node doesnt have any memory behind it then we will have to allocate from
another node. If the node we allocate from is a previous node then it
will have already been initialised by the bootmem allocator. Thus we
need to use bootmem in this case.

Its all a bit hairy but we need to support nodes with no memory behind
them.

Anton



More information about the Linuxppc64-dev mailing list