[PATCH] ppc64: fix gcc4 compile error in paca.h

Anton Blanchard anton at samba.org
Tue Mar 22 04:48:23 EST 2005


Thanks, looks good.

Anton

--

From: Mikael Pettersson <mikpe at csd.uu.se>

Compiling 2.6.12-rc1 or 2.6.12-rc1-mm1 for ppc64 with gcc4
fails with:

In file included from include/asm/spinlock.h:20,
                 from include/linux/spinlock.h:43,
                 from include/linux/signal.h:5,
                 from arch/ppc64/kernel/asm-offsets.c:17:
include/asm/paca.h:25: error: array type has incomplete element type
make[1]: *** [arch/ppc64/kernel/asm-offsets.s] Error 1
make: *** [arch/ppc64/kernel/asm-offsets.s] Error 2

This is an array-of-incomplete-type error.
Fix: move array decl to after the struct decl.

Signed-off-by: Mikael Pettersson <mikpe at csd.uu.se>
Signed-off-by: Anton Blanchard <anton at samba.org>

--- linux-2.6.12-rc1/include/asm-ppc64/paca.h.~1~	2005-03-02 19:24:19.000000000 +0100
+++ linux-2.6.12-rc1/include/asm-ppc64/paca.h	2005-03-21 15:29:26.000000000 +0100
@@ -22,7 +22,6 @@
 #include	<asm/iSeries/ItLpRegSave.h>
 #include	<asm/mmu.h>
 
-extern struct paca_struct paca[];
 register struct paca_struct *local_paca asm("r13");
 #define get_paca()	local_paca
 
@@ -115,4 +114,6 @@ struct paca_struct {
 #endif
 };
 
+extern struct paca_struct paca[];
+
 #endif /* _PPC64_PACA_H */



More information about the Linuxppc64-dev mailing list