CONFIG_NUMA and DISCONTIG inconsistencies

Dave Hansen haveblue at us.ibm.com
Tue Mar 22 02:56:10 EST 2005


First of all, what are the machines that require
        
        CONFIG_DISCONTIGMEM=y
        # CONFIG_NUMA is not set

That appears to be the ppc64 defconfig, and it doesn't make a lot of
sense to me.  First of all, why do you need DISCONTIG without NUMA?
Should that even be allowed?

Also, I see this:

static inline int pa_to_nid(unsigned long pa)
{
        int nid;

        nid = numa_memory_lookup_table[pa >> MEMORY_INCREMENT_SHIFT];
...
        return nid;
}

in mmzone.h under #ifdef CONFIG_DISCONTIGMEM.  Seems much more like a
NUMA thing to me.  Two completely untested patches to fix this up
attached.  Comments?  

-- Dave
-------------- next part --------------
A non-text attachment was scrubbed...
Name: A1-sparse-prep-ppc64-remove-numa-debug.patch
Type: text/x-patch
Size: 2569 bytes
Desc: not available
Url : http://ozlabs.org/pipermail/linuxppc64-dev/attachments/20050321/2786abc4/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: A2-sparse-prep-discontig-alone.patch
Type: text/x-patch
Size: 3411 bytes
Desc: not available
Url : http://ozlabs.org/pipermail/linuxppc64-dev/attachments/20050321/2786abc4/attachment-0001.bin 


More information about the Linuxppc64-dev mailing list