PCI Error Recovery API Proposal. (WAS:: [PATCH/RFC] PCI Error Recovery)

Linas Vepstas linas at austin.ibm.com
Wed Mar 16 08:44:13 EST 2005

On Tue, Mar 15, 2005 at 04:32:20PM +1100, Benjamin Herrenschmidt was heard to remark:
> Ok, let's propose what i think is a proper API and simple enough on the
> driver side, ...
> That
> should cover all the needs we discussed so far:
> I think we need a callback in pci_driver, as I explained all along, with
> a very simple semantic:
>    int (*error_handler)(struct pci_dev *dev, int message);

How about enum instead of int? that allows static type checking by
the compiler.


Elsewhere in the kernel, enums seem to be lowercase ... 

> Comments welcome. Linas, I'll give a try at coding something up in the
> upcoming days unless you beat me to it.

Looks good to me. This is a minor tweak on what I currently have,
so I'll take a shot at it.  Unfortunately I just lost my regular devel
machine.  And still haven't debugged the symbios recovery. 
It might take a few days, but what you wrote looks eminently workable.

Also, I have not completely read (or understood) what Long Nguyen 
just sent in... and haven't heard him make any remarks.  Sounds
to me like his AER patch is a pcie-specific version of what we are
talking about. It would be nice to hear for Long about his thoughts on


More information about the Linuxppc64-dev mailing list