[PATCH/RFC] PCI Error Recovery

Andi Kleen ak at muc.de
Sat Mar 12 20:52:32 EST 2005

On Fri, Mar 11, 2005 at 07:32:51PM -0600, Linas Vepstas wrote:
> Hi,
> Appended is my current draft PCI Error Recovery patch.  
> Per previous conversatios, it has moved some of the ppc64-specific 
> error reporting code into generic PCI structures: see changes to 
> include/linux/pci.h and a new file drivers/pci/pci-error.c.  Note 
> in particular the pci bus states enumerated in 
> "enum pci_device_io_state"; BenH was suggesting having
> more of these ... BenH do you want to propose a "final list"?

I don't like it very much that the frozen state is exposed
so clearly in the API.

e.g. on typical PCI Express chipsets there is no such concept.
With error reporting there you just get told "one of your 
previous accesses or DMAs failed", but the device is not
completely gone.

IMHO the concept of "slot freeze" is too PPC64 specific to
be exposed like this. While there are other chipsets
that do similar things a lot of widely used ones will not.

Can you reformulate it in terms of "error states" ?
Just report an error occurred and the device is unreliable.


More information about the Linuxppc64-dev mailing list