[PATCH 7/8] pSeries_smp.c: use pSeries reconfig notifier for cpu DLPAR

Nathan Lynch ntl at pobox.com
Fri Mar 11 12:53:39 EST 2005


On Thu, Mar 10, 2005 at 02:27:02PM -0600, Joel Schopp wrote:
> This patch seems fine.  Just a couple trivial comments.
> 
> >+static int pSeries_add_processor(struct device_node *np)
> 
> This function doesn't really add a processor;  it could use a better name.
>
> >+static void pSeries_remove_processor(struct device_node *np)
> 
> This doesn't remove a processor; it could also use a better name.
> 

They do add and remove processors in the sense that they update
cpu_present_map, which is the kernel's logical representation of the
cpus actually resident in the system.  I'm sort of drawing a blank
trying to think of alternatives.  If you've better ideas please share.


Nathan



More information about the Linuxppc64-dev mailing list