eeh.h compile warnings / adbhid.c build failure

[Nishanth Aravamudan]

On Thu, Mar 03, 2005 at 10:39:16AM +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2005-03-02 at 10:12 -0800, Nishanth Aravamudan wrote:
> > 
> > These warnings are emitted for pretty much every driver. It looks like
> > it is becuase with CONFIG_EEH undefined (it's a pSeries thing? -- my
> > interpretation from looking at the ppc64 Kconfig), eeh_check_failure()
> > becomes #define'd to simply it's second parameter, which in the case of
> > assignment statements ia statement with no effect. It's not a big deal,
> > the kernels still compile (with a patch to adbhid.c which I'll mention
> > in a second) but it's a lot of noise to be generated because I don't
> > have a pSeries machine...
> 
> Stupid gcc :)
> 
> > Now, to the build-blocking code:
> > 
> > In drivers/macintosh/adbhid.c::1159:
> > 
> > static int __init adbhid_init(void)
> > {
> > #ifndef CONFIG_MAC
> >         if ( (_machine != _MACH_chrp) && (_machine != _MACH_Pmac) )
> > 		return 0;
> > #endif
> > ...
> > 
> > I don't see CONFIG_MAC in my .config (attached below [1]), and _MACH_chrp is
> > not defined for ppc64 (it's in asm-ppc/processor.h not in
> > ppc64/processor.h. I just removed the _MACH_chrp conditional in my local
> > code to get the kernel to build. I'm not sure what the actual solution
> > is, but I thought you all should know about it.
> 
> There is no ADB bus on a G5, so the driver isn't useful anyway.
> Currently, ppc64 allows you to enable pmac drivers that won't build, but
> they also are useless on G5s. I'll fix that over time though.

Ok, I'll take it out of the config. Thanks!

-Nish