eeh.h compile warnings / adbhid.c build failure

Nishanth Aravamudan nacc at
Thu Mar 3 06:28:11 EST 2005

On Wed, Mar 02, 2005 at 11:20:06AM -0800, Brad Boyer wrote:
> On Wed, Mar 02, 2005 at 10:12:06AM -0800, Nishanth Aravamudan wrote:
> > Now, to the build-blocking code:
> > 
> > In drivers/macintosh/adbhid.c::1159:
> > 
> > static int __init adbhid_init(void)
> > {
> > #ifndef CONFIG_MAC
> >         if ( (_machine != _MACH_chrp) && (_machine != _MACH_Pmac) )
> > 		return 0;
> > #endif
> > ...
> > 
> > I don't see CONFIG_MAC in my .config (attached below [1]), and _MACH_chrp is
> > not defined for ppc64 (it's in asm-ppc/processor.h not in
> > ppc64/processor.h. I just removed the _MACH_chrp conditional in my local
> > code to get the kernel to build. I'm not sure what the actual solution
> > is, but I thought you all should know about it.
> The CONFIG_MAC symbol is defined for mac68k support. The m68k arch has a
> different way of telling the various machines apart, although I notice
> that there isn't an equivalent block here for that. I guess no other 68k
> people cared enough to make sure the ADB layer doesn't load on their boxes.
> In my opinion, the machine selectors should be reconciled between ppc and
> ppc64 due to the amount of code that expects them to act the same. So
> even though you wouldn't have a CHRP ppc64 box, the define will be there.

I definitely think this is the ideal solution. I did notice, though,
that hte _MACH_Pmac #define varies between ppc and ppc64, so I'm not
sure how that would work for _MACH_chrp. I am more than happy to
test code, generate patches (if you tell me what you'd like me to
change), etc.


More information about the Linuxppc64-dev mailing list