[PATCH 1/13]: PCI Err: pci.h header file changes

[Andi Kleen]

On Tue, Jun 28, 2005 at 05:29:51PM -0700, Greg KH wrote:
> On Tue, Jun 28, 2005 at 06:58:17PM -0500, Linas Vepstas wrote:
> > @@ -673,6 +704,7 @@ struct pci_driver {
> >  	int  (*enable_wake) (struct pci_dev *dev, pci_power_t state, int enable);   /* Enable wake event */
> >  	void (*shutdown) (struct pci_dev *dev);
> >  
> > +	struct pci_error_handlers err_handler;
> >  	struct device_driver	driver;
> >  	struct pci_dynids dynids;
> >  };
> 
> Shouldn't that be a pointer and not the whole structure?  Wouldn't that
> make it easier to "reuse" error handlers?

Yes, it's a good idea. In fact we could have a generic NIC error
handler structure then that just calls the watchdog timeout function.
I suspect that would be sufficient for most NICs.

-Andi