[PATCH 4/15] ppc64: Don't pass the pointers to xItLpQueue around

[Stephen Rothwell]

Hi Michael,

On Tue, 28 Jun 2005 09:17:17 +1000 Michael Ellerman <michael at ellerman.id.au> wrote:
>
>  	int t;
> -	u32 * inUseP = &(lpQueue->xInUseWord);
> +	u32 * inUseP = &xItLpQueue.xInUseWord;
>  
>  	__asm__ __volatile__("\n\
>  1:	lwarx	%0,0,%2		\n\
> @@ -31,37 +31,37 @@ static __inline__ int set_inUse( struct 
>  	stwcx.	%0,0,%2		\n\
>  	bne-	1b		\n\
>  2:	eieio"

Could you fix this assembler code up so that it is a set of concatenated
strings rather than one longe one, please?  I think that is the preferred
formatting these days.

>  
>  	/* If we have recursed, just return */
> -	if ( !set_inUse( lpQueue ) )
> +	if ( !set_inUse() )

You might as well do simple white space cleanups like thses along the way
(as you have done elsewhere).

>  			ItLpQueue_clearValid( nextLpEvent );
> -		} else if ( lpQueue->xPlicOverflowIntPending )
> +		} else if ( xItLpQueue.xPlicOverflowIntPending )

More whitespace.

>  			 */
> -			HvCallEvent_getOverflowLpEvents( lpQueue->xIndex);
> +			HvCallEvent_getOverflowLpEvents( xItLpQueue.xIndex);

And again.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://ozlabs.org/pipermail/linuxppc64-dev/attachments/20050628/4c4aa71f/attachment.pgp