[PATCH] prom_find_machine_type typo breaks pSeries lpar boot

Nathan Lynch ntl at pobox.com
Sat Jun 4 05:25:25 EST 2005


Typo in prom_find_machine_type from Ben's recent patch "ppc64: Fix
result code handling in prom_init" prevents pSeries LPAR systems from
booting.

Tested on a pSeries 570 and OpenPower 720 (both Power5 LPAR).

Signed-off-by: Nathan Lynch <ntl at pobox.com>

 arch/ppc64/kernel/prom_init.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.12-rc5-git8/arch/ppc64/kernel/prom_init.c
===================================================================
--- linux-2.6.12-rc5-git8.orig/arch/ppc64/kernel/prom_init.c
+++ linux-2.6.12-rc5-git8/arch/ppc64/kernel/prom_init.c
@@ -1370,7 +1370,7 @@ static int __init prom_find_machine_type
 	}
 	/* Default to pSeries. We need to know if we are running LPAR */
 	rtas = call_prom("finddevice", 1, 1, ADDR("/rtas"));
-	if (!PHANDLE_VALID(rtas)) {
+	if (PHANDLE_VALID(rtas)) {
 		int x = prom_getproplen(rtas, "ibm,hypertas-functions");
 		if (x != PROM_ERROR) {
 			prom_printf("Hypertas detected, assuming LPAR !\n");



More information about the Linuxppc64-dev mailing list