[PATCH] ppc64: fix call_prom return checks

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Jun 2 08:48:06 EST 2005


On Thu, 2005-06-02 at 00:20 +0200, Arnd Bergmann wrote:
> On Dunnersdag 02 Juni 2005 00:22, Benjamin Herrenschmidt wrote:
> > Hi Arnd, Paul !
> > 
> > What about this patch ? (untested at the moment). I'm never very
> > comfortable with those sign non-extension issues in prom_init ...
> 
> Why do you cast the values to 'long' in the first place

My patch is still doing that ? I though I was removing those casts ...

> Comparing two values of the same type would seem more intuitive.
> Aside from that, the patch looks good to me, I'll give it a test
> run on our firmware tomorrow.





More information about the Linuxppc64-dev mailing list