[PATCH] PCI device-node failure detection

Benjamin Herrenschmidt benh at kernel.crashing.org
Wed Jun 1 09:37:55 EST 2005


> Hmm...I thought we were trying to keep all device-tree specific items in
> prom.c.  

Not really. In fact, I want only "generic" device-tree stuff in there,
and that isn't quite it. I'm about to remove the bunch of
interpret_xxxx_props() for example, ultimately, I want prom.c to only
contain the structure accessors, flatten/unflatten code, etc..

Besides, if you really want to export it, considering that it's
"standard" enough to be in generic code, then it should be rather called
something like.

    int of_device_failed(...)

And finally, i'd rather have it backward, that is something like
of_device_available().

Ben.





More information about the Linuxppc64-dev mailing list