[PATCH]: PCI Error Recovery Implementation

[Linas Vepstas]

On Tue, May 31, 2005 at 05:13:11PM -0500, John Rose was heard to remark:
> > and what would be the correct way of invoking functions in that
> > module?
> 
> Arch/ppc64/kernel/eeh.c could have function pointers for enable/disable
> slot.  Something like:
> int (*hp_disable_slot)(struct pci_bus *bus) = NULL;
> int (*hp_enable_slot)(struct pci_bus *bus) = NULL;
> 
> These could either be exported, or be static and accompanied by small
> accessor functions.  The RPA hotplug module could set these pointers at
> module init, either directly or through accessors.  If these aren't set
> at runtime, the module isn't loaded.
> 
> This puts the eeh footprint on rpaphp at 4 lines, and leaves the EEH
> implementation in an eeh file.

That was the original implementation about a year ago.  Lengthly
discussion on the mailing lists suggested that this was the wrong way 
to do it.  I'm not sure, but  I vaguely remember Paul Mackerras as being 
(one of) the drivers urging the current implementation.

Paul, could you please comment on this issue?

Personally, I don't much care; either mechanism has the same net result.

--linas