[PATCH 10/11] ppc64: SPU file system

[Geoff Levand]

Arnd Bergmann wrote:
...
> --- linux-cg.orig/mm/memory.c	2005-06-21 22:48:42.154975624 -0400
> +++ linux-cg/mm/memory.c	2005-06-21 22:48:48.780899080 -0400
> @@ -2201,6 +2201,7 @@ unsigned long vmalloc_to_pfn(void * vmal
>  {
>  	return page_to_pfn(vmalloc_to_page(vmalloc_addr));
>  }
> +EXPORT_SYMBOL_GPL(handle_mm_fault);
>  
>  EXPORT_SYMBOL(vmalloc_to_pfn);
>  
 
Your change to handle_mm_fault causes problems when I build for Ebony (ppc32).

  mm/built-in.o(*ABS*+0xfe6822c0): In function `__crc_handle_mm_fault':
  shmem.c: multiple definition of `__crc_handle_mm_fault'
  make[1]: *** [.tmp_vmlinux1] Error 1

  $ egrep -HRn 'EXPORT_SYMBOL(_GPL)?\(handle_mm_fault' .
  ./mm/memory.c:2208:EXPORT_SYMBOL_GPL(handle_mm_fault);
  ./arch/ppc/kernel/ppc_ksyms.c:329:EXPORT_SYMBOL(handle_mm_fault); /* For MOL */


Also, it seems a definition of the DEFINE_SIMPLE_ATTRIBUTE macro is missing.  Did I miss one of your patches?

  CC      fs/spufs/file.o
  /home/geoff/projects/alp/alp-linux--dev-2-6-12--1.7/fs/spufs/file.c:401: error: parse error before string constant
  /home/geoff/projects/alp/alp-linux--dev-2-6-12--1.7/fs/spufs/file.c:401: warning: type defaults to `int' in declaration of `DEFINE_SIMPLE_ATTRIBUTE'
  ...

  $ egrep -HRn 'DEFINE_SIMPLE_ATTRIBUTE' .
  ./fs/spufs/file.c:400:DEFINE_SIMPLE_ATTRIBUTE(spufs_signal1_type, spufs_signal1_type_get,
  ./fs/spufs/file.c:414:DEFINE_SIMPLE_ATTRIBUTE(spufs_signal2_type, spufs_signal2_type_get,
  ./fs/spufs/file.c:428:DEFINE_SIMPLE_ATTRIBUTE(spufs_ ## name,           \
  ./fs/spufs/file.c:443:DEFINE_SIMPLE_ATTRIBUTE(spufs_ ## name,           \
  ./fs/spufs/file.c:458:DEFINE_SIMPLE_ATTRIBUTE(spufs_ ## name,           \

-Geoff