[PATCH 18/21] ppc64/rtasd: replace schedule_timeout() with msleep()

Paul Mackerras paulus at samba.org
Sat Jan 22 16:25:21 EST 2005


Nishanth Aravamudan writes:

> Description: Replace schedule_timeout() with msleep()/ssleep(). In both cases,
> the current code sleeps in TASK_INTERRUPTIBLE but does not account for early
> wakeups due to signals being caught; therefore I have used TASK_UNINTERRUPTIBLE
> sleeps in both cases. The second sleep is slightly more difficult to convert as
> rtas_event_scan_rate is variable. I have left it as a msleep() call, although
> ssleep() may be more appropriate.

You have a good point about signals, but I don't like the way that
this will elevate the load average by 1 the whole time.  We need to
fix this properly instead.

Paul.



More information about the Linuxppc64-dev mailing list