[PATCH 17/21] ppc64/pSeries_smp: replace schedule_timeout() with msleep()

Nishanth Aravamudan nacc at us.ibm.com
Tue Jan 18 11:15:22 EST 2005


Hi,

Please consider applying. 

Description: Use msleep() instead of schedule_timeout() to guarantee the task
delays as expected. The current code is not incorrect, but msleep() is clearer
in terms of the length of delay and helps make the kernel consistent.

Signed-off-by: Nishanth Aravamudan <nacc at us.ibm.com>

--- 2.6.11-rc1-kj-v/arch/ppc64/kernel/pSeries_smp.c	2005-01-15 16:55:41.000000000 -0800
+++ 2.6.11-rc1-kj/arch/ppc64/kernel/pSeries_smp.c	2005-01-15 17:21:12.000000000 -0800
@@ -107,8 +107,7 @@ void pSeries_cpu_die(unsigned int cpu)
 		cpu_status = query_cpu_stopped(pcpu);
 		if (cpu_status == 0 || cpu_status == -1)
 			break;
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout(HZ/5);
+		msleep(200);
 	}
 	if (cpu_status != 0) {
 		printk("Querying DEAD? cpu %i (%i) shows %i\n",



More information about the Linuxppc64-dev mailing list